Using libsodium for random bytes breaks plugin update in WP 4.4

[krakendancer]

Running WP 4.4 on
CentOS 7.2.1511
nginx 1.9.9
PHP 5.4.16
libsodium 1.0.5
php-pecl-libsodium 1.0.2

After updating to WP 4.4 plug-ins cannot be updated anymore.

Updates fail with

[06-Jan-2016 12:21:21 UTC] PHP Fatal error: Call to undefined function Sodium\randombytes_buf() in /var/www/verifyne.me/wp/wp-includes/random_compat/random_bytes_libsodium.php on line 69

The lines 66 and 69 state

\Sodium\randombytes_buf

whereas the following works for me

\Sodium::randombytes_buf

[dd32]

Hey @krakendancer Thanks for the report.

I've filed a bug upstream here: ​https://github.com/paragonie/random_compat/issues/85

According to ​the documentation, it's being called correctly, but perhaps not..

[sarciszewski]

\Sodium::

That syntax was dropped long before 1.0.0 was tagged. Please upgrade your extension to a stable version.

See also ​https://github.com/jedisct1/libsodium-php/issues/58 for a reason why you want to run, at minimum, version 1.0.1

[sarciszewski]

PHP 5.4.16
libsodium 1.0.5
php-pecl-libsodium 1.0.2

What is the ouput of the following script?

var_dump(
    Sodium::library_version_major(),
    Sodium::library_version_minor()
);

[krakendancer]

Supposing you mean

var_dump(
    Sodium::sodium_library_version_major(),
    Sodium::sodium_library_version_minor()
);

gives

int(7) int(6)

[dd32]

We'll update to master in trunk to bring in ​the fix.
However for the 4.4 branch we'll need to instead use 35327.44-branch.diff​ as we can't add new files in a point release.

[sarciszewski]

We tagged and released 1.1.5 just now, which should work for your setup.

[dd32]

In 36220:

Update to Random_Compat 1.1.5 to fix an issue with older libSodium modules.

Props sarciszewski.
Fixes #35327 for trunk.

[dd32]

In 36257:

Random_Compat: The version included with 4.4 only supports the PHP 5.2+ namespace version of libsodium, don't attempt to use it with PHP 5.2 or old libsodium versions.

Fixes #35327.