WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#35335 closed enhancement (fixed)

Pass data consistently between plugin, network plugin, and network theme screens.

Reported by: obenland Owned by: obenland
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords: shiny-updates has-patch
Focuses: multisite Cc:

Description

Working on Shiny Updates v2, I realized how fragmented the list table classes are that are used in the plugin, network plugin, and network theme screens.

To make it easier for Shiny Updates and other plugins to enhance these screens, and to remove the possibility for duplicate ID attributes, I'd like to remove ids with plugin/theme slugs and take advantage of data attributes to pass that information. This may overlap slightly with #18974, but goes beyond it on the themes side.

Attachments (1)

35335.diff (2.7 KB) - added by obenland 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @obenland
4 years ago

  • Owner set to obenland
  • Status changed from new to accepted

@obenland
4 years ago

#2 @adamsilverstein
4 years ago

  • Keywords has-patch added

This looks good @obenland - took me a while to find the theme table on the network theme page, I keep forgetting thats there. I'm sure we may have some plugins targeting that ID, however thats probably not a smart thing to do and if they really need to they can switch to targeting the data attribute.

Last edited 4 years ago by adamsilverstein (previous) (diff)

#3 @obenland
4 years ago

  • Focuses multisite added

@jeremyfelt, any objections?

#4 @jeremyfelt
4 years ago

No objections from me. I can't imagine it being to popular to target the current IDs for styling.

#5 @obenland
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 36394:

Pass data consistently on plugin, network plugin, and network theme screens.

List tables on these three screens look similar but come with unexpected caveats.
The network themes screen in particular has been neglected, using a .plugin
class to inherit its sibling's styles and not providing classes and data
attributes that the other two offer. This will provide some more consistency.

Fixes #35335.

Note: See TracTickets for help on using tickets.