Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#35350 closed enhancement (fixed)

Shiny Updates: Use plugin file rather than slug as identifier

Reported by: obenland's profile obenland Owned by: obenland's profile obenland
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.6
Component: Plugins Keywords: shiny-updates has-patch
Focuses: javascript, administration Cc:

Description

After [36205] we're now able to use the plugin file as a unique identifier for plugins. The slug can be ambiguous, as downloading Hello Dolly from the plugin repository reveals pretty easily.

Attachments (2)

hello-dolly.png (14.2 KB) - added by obenland 8 years ago.
Two plugins, same slug, unique plugin file.
35350.diff (5.0 KB) - added by obenland 8 years ago.

Download all attachments as: .zip

Change History (4)

@obenland
8 years ago

Two plugins, same slug, unique plugin file.

@obenland
8 years ago

#1 @adamsilverstein
8 years ago

  • Keywords has-patch added

Looks great @obenland:

I tested this patch and shiny updates continue to operate as expected on both the plugin screen and the install screen.

I appreciate the way you are bringing over bug fixes from the shiny updates feature plugin back into core! As you so elegantly describe, slugs may not be unique and this causes issues with shiny updates: using the plugin file/path itself ensures uniqueness and fixes these cases.

#2 @obenland
8 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 36221:

Plugins: Use plugin file rather than slug as identifier

The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.

See [36205].
Fixes #35350.

Note: See TracTickets for help on using tickets.