Opened 9 years ago
Closed 9 years ago
#35350 closed enhancement (fixed)
Shiny Updates: Use plugin file rather than slug as identifier
Reported by: | obenland | Owned by: | obenland |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Plugins | Keywords: | shiny-updates has-patch |
Focuses: | javascript, administration | Cc: |
Description
After [36205] we're now able to use the plugin file as a unique identifier for plugins. The slug can be ambiguous, as downloading Hello Dolly from the plugin repository reveals pretty easily.
Attachments (2)
Change History (4)
#1
@
9 years ago
- Keywords has-patch added
Looks great @obenland:
I tested this patch and shiny updates continue to operate as expected on both the plugin screen and the install screen.
I appreciate the way you are bringing over bug fixes from the shiny updates feature plugin back into core! As you so elegantly describe, slugs may not be unique and this causes issues with shiny updates: using the plugin file/path itself ensures uniqueness and fixes these cases.
Note: See
TracTickets for help on using
tickets.
Two plugins, same slug, unique plugin file.