WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 9 years ago

#35358 closed enhancement (fixed)

Values of 0 doesn't need to have units specified in .scss file

Reported by: MatheusFD Owned by: swissspidy
Priority: normal Milestone: 4.8
Component: Administration Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

If we are using .scss files to simplify our CSS writing, let's improve this to write less and do more!

The patch just removes the unit px from the .scss file.

Attachments (1)

35358.patch​ (523 bytes ) - added by MatheusFD 11 years ago.
Just remove the px unit from .scss file

Download all attachments as: .zip

Change History (6)

@MatheusFD
11 years ago

Just remove the px unit from .scss file

#1 @MatheusFD
11 years ago

http://i.imgur.com/m85yfo9.png

We don't need to use -webkit- too for box-shadow. IE8 doesn't offers support even with engine. Either for Opera Mini

#2 @MatheusFD
11 years ago

  • Keywords has-patch 2nd-opinion added

#3 @swissspidy
10 years ago

  • Keywords 2nd-opinion removed
  • Milestone Awaiting Review → 4.8
  • Owner set to swissspidy
  • Status new → accepted

We can easily apply 35358.patch​. Output is the same because of autoprefixer. Example:

.media-selection .attachment.selection.details .thumbnail {
  -webkit-box-shadow: 0 0 0 1px #fff, 0 0 0 3px #096484;
  box-shadow: 0 0 0 1px #fff, 0 0 0 3px #096484;
}

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs.
9 years ago

#5 @swissspidy
9 years ago

  • Resolution → fixed
  • Status accepted → closed

In 40576:

Administration: Remove unit and prefixed version from a CSS declaration.

The prefixed version gets added by Autoprefixer already.

Props MatheusFD.
Fixes #35358.

Note: See TracTickets for help on using tickets.