#35367 closed defect (bug) (fixed)
Documented attributes for audio shortcode misleading (also video).
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Media | Keywords: | has-patch has-unit-tests commit |
Focuses: | docs | Cc: |
Description
The header doc for the audio shortcode wp_audio_shortcode
function lists class
and style
as attributes, but they aren't really as they're just ignored if given. Similarly for the video shortcode class
attribute.
Attachments (1)
Change History (9)
#1
@
9 years ago
- Keywords has-patch has-unit-tests added
- Milestone changed from Awaiting Review to 4.5
- Version changed from 3.9 to 3.6
#2
follow-up:
↓ 3
@
9 years ago
Wow that was quick! Would the filters best be kept though for BC, eg apply_filters( 'wp_audio_shortcode_class', $atts['class'] )
?
#3
in reply to:
↑ 2
@
9 years ago
Replying to gitlost:
Wow that was quick! Would the filters best be kept though for BC, eg
apply_filters( 'wp_audio_shortcode_class', $atts['class'] )
?
Yes. As you can see in the patch, I did not remove the filters. I just moved them two lines up.
Note: See
TracTickets for help on using
tickets.
Yeah, that sounds like a bug.
35367.diff does:
class
andstyle
attributes get correctly passedclass
attribute filters are right before theapply_filters
call