WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#35377 closed enhancement (fixed)

Add author_url to WP_Comment_Query

Reported by: dshanske Owned by: boonebgorges
Priority: normal Milestone: 4.5
Component: Comments Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description

Add argument to query author_url to WP_Comment_Query. I reread the code multiple times. This is not an option.

I have a different proposal to streamline the pingback_ping code, and it searches for duplicate pingbacks before accepting a new one. Using WP_Comment_Query would be superior to the direct database call currently performed.

Attachments (1)

35377.diff​ (3.3 KB ) - added by swissspidy 11 years ago.

Download all attachments as: .zip

Change History (7)

@swissspidy
11 years ago

#1 @swissspidy
11 years ago

  • Keywords has-patch has-unit-tests added

Is 35377.diff​ already enough? If you want matches using LIKE you can use the search param.

#2 @dshanske
11 years ago

That's exactly it.

#3 @boonebgorges
11 years ago

  • Milestone Awaiting Review → 4.5

#4 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution → fixed
  • Status new → closed

In 36224:

Introduce 'author_url' param to WP_Comment_Query.

Props swissspidy.
Fixes #35377.

#5 @boonebgorges
11 years ago

In 36279:

Use assertEqualSets() in comment_author test.

The previous assertion was too specific, resulting in race conditions.

See #35377.

#6 @DrewAPicture
11 years ago

In 36834:

Docs: Standardize the changelog entry for the new $author_url argument, introduced in [36224].

See #35377. See #35986.

Note: See TracTickets for help on using tickets.