WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #35379, comment 12


Ignore:
Timestamp:
04/14/2016 04:12:02 PM (4 years ago)
Author:
codex-m
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35379, comment 12

    initial v1  
    11Thanks @flixos90 / @jeremyfelt for the update. I merged the final patch from this ticket #35698. Attached is the final patch (35379.3.diff) which is now a combination of the two patches. Basically it now illustrates the concept of adding `$context` which will have a value of 'network' for multisite implementation. And also the `$context_id` which will have the value of network ID when used with multisite. As suggested, I illustrated $context_id instead of $network_id for a more flexible implementation.
    22
    3 I re-tested this manuall and also using our automated testing. Works great. This also fixes the original issue being reported in this ticket. The unit test to cover these changes is 35379_unit_test.2.diff (previously attached).
     3I re-tested this manually and also using our automated unit testing (including the attached unit tests previously). This is working great and fixes the original issue being reported in this ticket. The unit test to cover these changes is 35379_unit_test.2.diff (previously attached).
    44
    55Let me know what you think :)