WordPress.org

Make WordPress Core

Attachments (2)

35380.patch (189.9 KB) - added by ocean90 4 years ago.
35380.2.patch (159.7 KB) - added by ocean90 3 years ago.
https://github.com/jquery/jquery/compare/1.12.2...1.12.3

Download all attachments as: .zip

Change History (26)

@ocean90
4 years ago

#1 follow-up: @ocean90
4 years ago

jQuery 1.12.0 is currently broken in combination with jQuery UI 1.11.4 and jQuery Migrate 1.2.1, see https://jsfiddle.net/7unv8rrm/2/. Pinged Scott about this.

#2 in reply to: ↑ 1 @ocean90
4 years ago

Replying to ocean90:

jQuery 1.12.0 is currently broken in combination with jQuery UI 1.11.4 and jQuery Migrate 1.2.1, see https://jsfiddle.net/7unv8rrm/2/. Pinged Scott about this.

Fixed upstream: https://github.com/jquery/jquery-migrate/issues/128

#3 @ocean90
4 years ago

  • Description modified (diff)
  • Summary changed from Update jQuery to 1.12.0 to Update jQuery to 1.12.0 and jQuery Migrate to 1.3.0

#5 @ocean90
4 years ago

jQuery Migrate added a few more warnings for features that have been deprecated. Leaving this open until all warnings have been solved.

#6 @ocean90
4 years ago

In 36286:

jQuery: Replace the use of the .size() method with the .length property.

The .size() method is deprecated since jQuery 1.8. The .length property is preferred because it doesn't have the overhead of a function call.

See https://api.jquery.com/size/.
See #35380.

#7 @ocean90
4 years ago

In 36287:

jQuery: Replace use of the .load() method for the "load" event with .on( 'load', handler ).

The shortcut is deprecated since jQuery 1.8.

See http://api.jquery.com/load-event/.
See #35380.

#8 @ocean90
4 years ago

In 36288:

jQuery: Replace $( document ).on( 'ready', fn ) with $( fn ).

The 'ready' event is deprecated since jQuery 1.8.

See https://github.com/jquery/jquery-migrate/blob/1.3.0/warnings.md#jqmigrate-ready-event-is-deprecated.
See #35380.

#9 @ocean90
4 years ago

  • Keywords needs-testing removed
  • Resolution set to fixed
  • Status changed from new to closed

#10 @lovememore
3 years ago

  • Type changed from defect (bug) to enhancement

Hi folks - jQuery 1.12.1 is available now which fixes a few issues. It'd be good to update to that.
http://blog.jquery.com/2016/02/22/jquery-1-12-1-and-2-2-1-released/

#11 @ocean90
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#12 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from reopened to closed

#13 @lovememore
3 years ago

Hi (again!) folks - jQuery 1.12.2 is available now which fixes a few more issues. It'd be good to update to that.
http://blog.jquery.com/2016/03/17/jquery-1-12-2-and-2-2-2-released/

#14 @dd32
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

re-opening for review, @ocean90 can you handle this again?

Changelog: https://github.com/jquery/jquery/compare/1.12.1...1.12.2

#15 @ocean90
3 years ago

  • Status changed from reopened to accepted

#17 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 37072:

External Libraries: Update jQuery Migrate to 1.4.0.

Changes: https://github.com/jquery/jquery-migrate/compare/1.3.0...1.4.0

Fixes #35380.

#18 @lovememore
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi (again!) folks - jQuery 1.12.3 is available now which fixes a couple more issues. It'd be good to update to that.
REF: http://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/

This ticket was mentioned in Slack in #core by mike. View the logs.


3 years ago

#20 @ocean90
3 years ago

  • Keywords commit added

#21 @jorbin
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 37164:

External Libraries: Update jQuery to 1.12.3.

Sing it with me: jQuery fixed two issues, now you can get them with WP 4.5.

Release Post: http://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.2...1.12.3

Fixes #35380.
Props ocean90.

#22 follow-up: @Presskopp
3 years ago

What can we do to make google host jquery 1.12.3 at
https://ajax.googleapis.com/ajax/libs/jquery ?

see also
https://wordpress.org/support/topic/google-not-yet-hosting-jquery-for-wp-45

I know it's not exactly regarding core, but whom could I ask?

#23 in reply to: ↑ 22 @peterwilsoncc
3 years ago

Replying to Presskopp:

What can we do to make google host jquery 1.12.3 at
https://ajax.googleapis.com/ajax/libs/jquery ?

That's a question best asked of the jQuery team at http://jquery.com/. I do know Google usually takes a little while to update their CDN.

#24 @lovememore
3 years ago

FYI: Google have updated their CDN with the jquery 1.12.3 now.

Note: See TracTickets for help on using tickets.