WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #35381, comment 3


Ignore:
Timestamp:
04/28/2016 08:01:38 PM (2 years ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35381, comment 3

    initial v1  
    77* Besides the `$suppress_filters` argument, I also added a `no_found_rows` argument (similar to other query classes) and a `$count` argument. The latter is already present through `$fields = 'count'`, but I thought we could standardize it, similar to the other query classes. It's a duplicate though, so if that is an issue, maybe we can deprecate `$fields = 'count'` - or otherwise get rid of `$count` again if there's no other way.
    88* Another problem in my opinion is the `get_terms_fields` filter. Since this class always queries for IDs (or a count), using the `get_terms_fields` filter to modify the requested fields in any way will most probably mess up the query - it's basically not of any use at this point. I wonder if we can deprecate/drop it - it does not affect what the query returns anyway with this implementation.
     9* I added a private `_prime_term_caches()` function, similar like we have for posts and comments. This function is used internally by the query class.