Opened 9 years ago
Closed 5 years ago
#35386 closed enhancement (invalid)
Refining Walker code
Reported by: | Funkatronic | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch needs-unit-tests needs-refresh close |
Focuses: | performance | Cc: |
Description
This a simple patch for the Walker class. Previously, if root was not 0, a second for loop was performed in the walk function. This new code does the same functionality with less loops
Attachments (1)
Change History (6)
This ticket was mentioned in Slack in #core by noisysocks. View the logs.
5 years ago
Note: See
TracTickets for help on using
tickets.
Hi @Funkatronic. Thanks for creating this ticket and submitting the patch. I realise some time has passed, is this something you're still interested in following up on?
I tried applying the patch, but it looks like it was somehow generated with an absolute path (C:/Users/manny/AppData/Local/Temp/class-wp-walker.php-revBASE.svn000.tmp.php). Usually a patch would have a path relative to the root of the project like 'src/wp-includes/class-wp-walker.php'.
There are some guides to creating patches here if you're interested in refreshing this patch:
Thanks!