WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #35391, comment 13


Ignore:
Timestamp:
01/02/2020 11:25:51 PM (21 months ago)
Author:
audrasjb
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35391, comment 13

    initial v1  
    11Hi,
     2
     3In my opinion, it would be better to reconsider the initially proposed patch as it still solves the issue. Also, I tested it it's looking pretty good on my side.
     4
    25`35391.1.diff` refreshes the previous patch and adds some fresh docs.
    36Concening the `mode` @param tag, I'm wondering if we should use "Optional" (like I did in the patch) or "Deprecated", as this parameter is no longer needed.