WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#35401 closed defect (bug) (fixed)

Taxonomies Quick Edit: prevent page reload when submitting

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 4.4.2 Priority: normal
Severity: normal Version: 4.4
Component: Quick/Bulk Edit Keywords: has-patch fixed-major
Focuses: ui, javascript Cc:

Description

In [35605] the Quick Edit "Cancel" and "Update" links were changed in buttons so at first sight it made sense to remove return false to prevent the default links action.

By the way, the form can still be submitted when pressing Enter on a focused field and when this happens there's now a page reload.

Attachments (1)

35401.patch​ (758 bytes) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (5)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

The proposed patch simply restores the missing return false; and adds a comment in both inline-edit-tax.js and inline-edit-post.js.

#2 @afercia
9 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 36260:

Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.

Fixes #35401 for trunk.

#3 @afercia
9 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.4.2,

#4 @dd32
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 36355:

Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.

Merges [36260 to the 4.4 branch.
Props afercia.
Fixes #35401.

Note: See TracTickets for help on using tickets.