WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#35401 closed defect (bug) (fixed)

Taxonomies Quick Edit: prevent page reload when submitting

Reported by: afercia Owned by: afercia
Priority: normal Milestone: 4.4.2
Component: Quick/Bulk Edit Version: 4.4
Severity: normal Keywords: has-patch fixed-major
Cc: Focuses: ui, javascript

Description

In [35605] the Quick Edit "Cancel" and "Update" links were changed in buttons so at first sight it made sense to remove return false to prevent the default links action.

By the way, the form can still be submitted when pressing Enter on a focused field and when this happens there's now a page reload.

Attachments (1)

35401.patch​ (758 bytes ) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (5)

@afercia
11 years ago

#1 @afercia
11 years ago

  • Keywords has-patch added

The proposed patch simply restores the missing return false; and adds a comment in both inline-edit-tax.js and inline-edit-post.js.

#2 @afercia
11 years ago

  • Owner set to afercia
  • Resolution → fixed
  • Status new → closed

In 36260:

Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.

Fixes #35401 for trunk.

#3 @afercia
11 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening for 4.4.2,

#4 @dd32
11 years ago

  • Resolution → fixed
  • Status reopened → closed

In 36355:

Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.

Merges [36260 to the 4.4 branch.
Props afercia.
Fixes #35401.

Note: See TracTickets for help on using tickets.