Bug with lightbox-gallery

[m266]

Hi,
since WP 4.4 is this a bug: https://core.trac.wordpress.org/ticket/34826
And the bug is in WP 4.4.1 too.
Have you a solution for the next release?
Thanks.

Best regards

[m266]

screenshot for bugfix

[Clorith]

Hi, and welcome to Trac!

In this situation, we actually need the rel attribute to be a part of the variable, as you can see on line 130 we use the $rel variable directly:

$html = '<a href="' . esc_attr($url) . "\"$rel>$html</a>";

Since we output it here, we expect it to contain the rel attribute tag, as well as the content of the tag.

The adjustment mentioned in #34826 changes it so we send the values that would make the else part trigger.

If you are experiencing the double rel attributes still, I'd recommend trying to clear your local cache first, as it may just be something sticking around locally, but of course if you continue to experience it do follow up on this ticket and we'll be happy to revisit it with you.

[m266]

Hi Clorith,

thanks for your answer.
Lightbox Plus Colorbox worked not since WP 4.4 (cache is empty) without the small hack in media.php. I must then use another plugin probably unfortunately.

Best regards

Replying to Clorith:

Hi, and welcome to Trac!

In this situation, we actually need the rel attribute to be a part of the variable, as you can see on line 130 we use the $rel variable directly:

$html = '<a href="' . esc_attr($url) . "\"$rel>$html</a>";

Since we output it here, we expect it to contain the rel attribute tag, as well as the content of the tag.

The adjustment mentioned in #34826 changes it so we send the values that would make the else part trigger.

If you are experiencing the double rel attributes still, I'd recommend trying to clear your local cache first, as it may just be something sticking around locally, but of course if you continue to experience it do follow up on this ticket and we'll be happy to revisit it with you.