WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#35413 closed defect (bug) (invalid)

Fix in docs for `wp_get_attachment_url` function

Reported by: sebastian.pisula Owned by: swissspidy
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: Cc:
PR Number:

Description

  • @global string $pagenow

global $pagenow isn't use

Attachments (1)

35413.patch (517 bytes) - added by sebastian.pisula 4 years ago.

Download all attachments as: .zip

Change History (7)

#1 @swissspidy
4 years ago

  • Component changed from General to Media
  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.5

#2 @swissspidy
4 years ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 36268:

Docs: Fix incorrect DocBlock for wp_get_attachment_url().

The documented $pagenow global isn't used in the function.

Props sebastian.pisula.
Fixes #35413.

#3 @swissspidy
4 years ago

  • Type changed from enhancement to defect (bug)

#4 @swissspidy
4 years ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

My bad, the global is indeed used, just as $GLOBALS['pagenow'] and I didn't see it, even after checking twice.

Will change it back.

#5 @swissspidy
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 36269:

Docs: Revert [36268] as the global is indeed used, just via the superglobal.

Fixes #35413.

#6 @ocean90
4 years ago

  • Milestone 4.5 deleted
  • Resolution changed from fixed to invalid
Note: See TracTickets for help on using tickets.