Walker_Comment::comment calls comment_text which forces the comment to be re-queried rather than use $comments variable cache

[pcfreak30]

On line 282, by passing get_comment_id() you are causing the comment to be re-fetched rather than pull from the $comments array. This causes the filter comments_array to be bypassed and possibly others. If This is changed to false, null, 0, etc it uses correct data.

[ocean90]

trunk/src/wp-includes/class-walker-comment.php?annotate=blame#L282​

This was introduced in [25555] for #14856.

[pcfreak30]

Actually this is still present in the latest version. 3.7 did not fix this or I would not have opened the issue.

[rachelbaker]

Passing the entire WP_Comment object to the comment_text function

[rachelbaker]

In 35433.diff​ instead of passing the comment_id, requiring the WP_Comment object to be re-fetched, I am passing in the WP_Comment object, which should prevent the additional query. @pcfreak30 would you be able to test the patch here?

[pcfreak30]

@rachelbaker I am not in a position to test this any further. This was found on a clients site and I do not have access to reproduce to try and test.

[wonderboymusic]

In 37325:

Comments: pass $comment to comment_text() in Walker_Comment::comment() instead of using a function which can skip the cache.

Props rachelbaker.
Fixes #35433.