Allow selective plugins to load for wp-activate.php

[pbearne]

while installing s2member on multi-site you need to edit load.php to allow all plugins to be loaded

So this patch adds a filter to allow you select a set of plugins that should be loaded when loading wp-activate.php to allow plugins to modify the activation process

[pbearne]

patch

[ericlewis]

Hi @pbearne, thanks for opening this ticket.

Active plugins are ​retrieved via a site option. Thereby, the list of active plugins could be modified with the
​option_active_plugins filter.

We should get in contact with the s2member authors and make them aware of these tickets and get them involved :) Happy to consider changes where core can do better by plugins, but some of these changes should happen downstream (in the plugin).

[pbearne]

related patches

https://core.trac.wordpress.org/ticket/35422
https://core.trac.wordpress.org/ticket/35427
https://core.trac.wordpress.org/ticket/35428
https://core.trac.wordpress.org/ticket/35443

and github ticket
​https://github.com/websharks/s2member/issues/842

[pbearne]

Replying to ericlewis:

Hi @pbearne, thanks for opening this ticket.

Active plugins are ​retrieved via a site option. Thereby, the list of active plugins could be modified with the
​option_active_plugins filter.

We should get in contact with the s2member authors and make them aware of these tickets and get them involved :) Happy to consider changes where core can do better by plugins, but some of these changes should happen downstream (in the plugin).

Already talking to s2members team (or trying to)

the problem is that on ​line 593 an empty array to returned

the patch that s2members is install is this

<?php
// Modified for full plugin compatiblity.
    //if ( empty( $active_plugins ) || wp_installing() )
    if ( empty( $active_plugins ) || ( wp_installing() && !preg_match("/\/wp-activate\.php/", $_SERVER["REQUEST_URI"]) ) )
    return $plugins;

I added the filter so that by default we didn't load any plugins but rather had to select them as felt that is was better to load only what is need while installing / activating a site

Thoughts?

Paul

[pbearne]

screenshot of s2member patch instructions

[pbearne]

fixed patch

[pbearne]

lets fix the spelling and formating

[jeremyfelt]

Is this a duplicate of #23197? If we modify things in a way confident enough to allow selective plugins, we may be able to load all plugins instead.

[pbearne]

loading all plugins would a better fix

[ericlewis]

Replying to jeremyfelt:

Is this a duplicate of #23197?

I think we can consider it a duplicate.

[jeremyfelt]

Duplicate of #23197.

Yeah, if we can find the right way to enable plugins for wp-activate.php, this ticket should fall into place.