Theme installer upload button improvements
|Reported by:||afercia||Owned by:||afercia|
See related #35429.
The "Upload Theme/Browse" button is built with two links with href="#" attributes but since it doesn't point to any resource and just "does something" it should be marked up as a button element.
Also, should use an aria-expanded attribute to be dynamically updated to give feedback about the status of the expandable uploader panel.
Worth noting that, when using a keyboard, activating the button causes a focus loss since the button is the currently focused element and then gets hidden to reveal the other button. This should definitely be avoided because keyboard users will be forced to start navigating again from the root of the document (especially noticeable using Chrome).
Change History (36)
- Keywords needs-patch added
- Milestone set to 4.5
- Owner set to afercia
- Status changed from new to assigned
- Keywords has-patch has-screenshots added; needs-patch removed
- Milestone changed from Future Release to 4.6
- Keywords commit removed
- Resolution fixed deleted
- Status changed from closed to reopened