Update has_excerpt()

[sebastian.pisula]

I think that has_excerpt function should be return bool value from get_the_excerpt(). This is update after fix: [36319] where we can filter excerpt

[swissspidy]

Hmm this could lead to false positives where the excerpt has been filtered or when it is a private post.

For example, get_the_excerpt() returns 'There is no excerpt because this is a protected post.' for private posts, but has_excerpt() returns false. With this patch, it would return true.

Sounds like a wontfix because of BC issues.

[sebastian.pisula]

Replying to swissspidy:

Hmm this could lead to false positives where the excerpt has been filtered or when it is a private post.

For example, get_the_excerpt() returns 'There is no excerpt because this is a protected post.' for private posts, but has_excerpt() returns false. With this patch, it would return true.

Sounds like a wontfix because of BC issues.

I think that this work good. Because for private post the excerpt is 'There is no excerpt because this is a protected post.'. Maybe add new param - $private_excerpt = true and in has_exceprt function get_the_excerpt($post_id, false) ? Example in patch.

[swissspidy]

That still changes the semantics of the function. get_the_excerpt() is almost never empty because wp_trim_excerpt() is hooked to the get_the_excerpt filter.

has_excerpt() checks if there's a custom excerpt, not if there's some generated excerpt.

[sebastian.pisula]

current fuction work bad too because in $post->post_excerpt I will be have excerpt and in get_the_excerpt I use filter to remove excerpt so has_excerpt() return true and get_the_excerpt return empty string -> except not exists

[swissspidy]

Replying to sebastian.pisula:

current fuction work bad too because in $post->post_excerpt I will be have excerpt and in get_the_excerpt I use filter to remove excerpt so has_excerpt() return true and get_the_excerpt return empty string -> except not exists

This sounds like an edge case. If you do that and you want to make sure get_the_excerpt() is not empty, just use if ( get_the_excerpt() { … } instead of has_excerpt().

The ticket really is a wontfix in my eyes because it breaks backwards-compatibility. Devs expect it to check $post->post_excerpt and not get_the_excerpt().

[SergeyBiryukov]

In 40042:

Docs: Clarify that has_excerpt() checks if the post has a custom excerpt, not some generated excerpt.

See #35487.

[SergeyBiryukov]

Replying to swissspidy:

has_excerpt() checks if there's a custom excerpt, not if there's some generated excerpt.

[40042] clarifies that in the function description.

I agree with comment:6, changing it now would break backwards compatibility.