Opened 9 years ago
Closed 7 years ago
#35496 closed defect (bug) (fixed)
Quick Edit error messages UI improvements
Reported by: | afercia | Owned by: | afercia |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Quick/Bulk Edit | Keywords: | has-screenshots has-ui-feedback has-patch |
Focuses: | ui | Cc: |
Attachments (6)
Change History (17)
#3
@
8 years ago
I think having them red is good. I almost want full on error messages though with boxes and everything. They merge a little too much for me just as text. However, I do wonder if making them an error box will be overkill.
I wonder a little on positioning, the message seems to float without connecting to an action in a few of those screenshots. Could we use this as a chance to bring the message to the action also?
#4
@
8 years ago
+1 for a regularly styled error message, even if it does feel a little overkill. Attaching some ideas.
#5
@
8 years ago
+1 to that @melchoyce - looks so much better with a box and error message that way.
#7
@
7 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 4.9
- Owner set to afercia
- Status changed from new to assigned
35496.diff changes the error messages to use inline notices. Also adds some missing periods to some error messages. A few screenshots:
#8
@
7 years ago
One note, we'll want to use the .notice-alt
class here since the notice is on a white background.
#9
@
7 years ago
Actually, the notices are on a zebra striped background, depending on the line the background is white or light gray. Patch updated with the notice-alt
style. Screenshot:
One thing I personally don't like so much about the notice-alt
style is that it lacks the bottom box-shadow, making the notice look "flat". any specific reason for this?
Yep, just prepared a screenshot for Quick Edit and Reply errors for comments :)