Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#35499 closed enhancement (fixed)

Add the ability to parse a whole directory with add-textdomain.php

Reported by: iamntz Owned by: ocean90
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:


Just like the title says: currently the add-textdomain.php tool doesn't allows anything but single files. This patch will detect if the passed argument is either a file or a directory and it will act accordingly.

Attachments (1)

add-textdomain.php.patch (677 bytes) - added by iamntz 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @johnbillion
5 years ago

  • Component changed from I18N to Build/Test Tools
  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

#2 @jorbin
5 years ago

@nbachiyski and @ocean90 as the resident Internationalization specialists, can you take a look at this?

#3 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 36600:

i18n-tools: Add the ability to parse a whole directory with add-textdomain.php.

Props iamntz.
Fixes #35499.

#4 @ocean90
5 years ago

  • Keywords needs-testing removed
  • Milestone changed from Future Release to WordPress.org

Thanks @iamntz. Adjusted the code a bit because SplFileInfo (http://php.net/manual/en/class.splfileinfo.php) includes the extension already. Take also a look at our coding standards.

#5 @ocean90
5 years ago

  • Component changed from Build/Test Tools to I18N
Note: See TracTickets for help on using tickets.