WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #35501, comment 12


Ignore:
Timestamp:
07/15/2016 08:14:57 PM (5 years ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35501, comment 12

    initial v1  
    44
    55In [attachment:35501.4.patch] I cleaned up the patch a tiny bit, adding brackets around the single line conditionals, switching to 'yoda conditionals', adding periods at the end of the comment blocks and adding a blank line above each single comment line.
     6
     7The only possible issue I could see with this code is if the users connection drops the links will remain inactive, however that issue would occur with the 'disabling link' approach; refreshing the page after the connection comes back would of fix the issue. We could add a timeout catch for failures and reset the xhr object, but I think the added complexity isn't worth the effort.