Opened 9 years ago
Closed 9 years ago
#35511 closed defect (bug) (fixed)
Remove even more unused local variables
Reported by: | Latz | Owned by: | rachelbaker |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | 4.4 |
Component: | Comments | Keywords: | has-patch |
Focuses: | Cc: |
Description
There are several local variables in "comment-template.php" which aren't used anymore.
Attachments (1)
Change History (8)
#5
@
9 years ago
@Latz The comments_template()
function is tricky because the variables set may be used in your theme's comments.php
file. Example: I can see $comment_author_url
used in theme-compat/comments.php
.
Before any of the globals or local variables are removed from comments_template()
some research and testing will need to be done across the theme directory.
#6
@
9 years ago
Replying to rachelbaker:
The
comments_template()
function is tricky because the variables set may be used in your theme'scomments.php
file. Example: I can see$comment_author_url
used intheme-compat/comments.php
.
I have to admit that I hadn't thought that far. Will take a look but it at first sight it seems like a strange programming style.
In 36343: