Make WordPress Core

Opened 11 years ago

Last modified 2 months ago

#35530 new enhancement

Style and upgrade "Briefly unavailable for scheduled maintenance. Check back in a minute." page

Reported by: tw2113 Owned by:
Priority: normal Milestone: Awaiting Review
Component: Upgrade/Install Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

While ideally it would not be shown except briefly, the current display of the "Briefly unavailable for scheduled maintenance. Check back in a minute." feels very unprofessional and generic. Perhaps we should consider dropping the message into some output similar to the readme.html file.

Thoughts?
Concerns?

Change History (7)

#1 @ericlewis
11 years ago

Looks like maintenance check happens too early to utilize wp_die(), but perhaps some basic styles could be borrowed from its template?

#2 follow-up: @dd32
11 years ago

The template was deliberately kept minimal and non-WordPressy for the same reason which we removed the styling from the database-is-down message - There's no reason to connect either of those "errors" to WordPress directly, once upon a time people would see the database-is-down message and blame WordPress, that happens a little less now, as it's a little more obvious where the problem lies.

When the total upgrade time of WordPress is generally sub-20-seconds (which means maintenance mode will be even less) and background-minor-updates average something much faster, sub-10-seconds I'm not sure too much effort should be put into the design of that screen.

#3 @tw2113
11 years ago

Perhaps just a gray background and centered text, keep the WP logo off the top. I agree with keeping it minimal, but a tiny bit of styling wouldn't hurt.

No hard feelings if wontfix, also.

#4 in reply to: ↑ 2 @ericlewis
11 years ago

Replying to dd32:

The template was deliberately kept minimal and non-WordPressy for the same reason which we removed the styling from the database-is-down message - There's no reason to connect either of those "errors" to WordPress directly

The database-is-down message makes sense to keep minimal, as that could be for any number of reasons not related to WordPress. However, maintenance mode is a WordPress construct, so using WordPress styling seems right here.

This ticket was mentioned in Slack in #core by clorith. View the logs.


9 years ago

This ticket was mentioned in PR #12209 on WordPress/wordpress-develop by @dpknauss.


2 months ago
#6

  • Keywords has-patch added

## Summary

  • Updates the default maintenance-mode message from “Check back in a minute.” to “Check back shortly.”

## Why
The default maintenance response sends Retry-After: 600, and wp_is_maintenance_mode() can continue blocking normal boot while the timestamped .maintenance lockfile is less than 10 minutes old. In normal successful updates the interruption is usually much shorter, but in common interrupted-update cases “in a minute” can be objectively misleading.

“Shortly” keeps the message concise without promising a specific duration.

## Testing

  • php -l src/wp-includes/load.php

#7 @dpknauss
2 months ago

This messaging has bugged me for ages, so I'm happy to discover (and join) this old ticket. I think the key thing to do away with is the "a minute" language, which suggests a 60s duration. The typical failure case that leaves people scratching their heads is a 600s lockout.

Last edited 2 months ago by dpknauss (previous) (diff)
Note: See TracTickets for help on using tickets.