WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#35552 closed defect (bug) (fixed)

Added pointer cursor on theme, plugin, and media uploader

Reported by: Ankit K Gupta Owned by: afercia
Milestone: 4.7 Priority: normal
Severity: normal Version: 3.9
Component: Upload Keywords: has-patch has-screenshots
Focuses: ui, accessibility, administration Cc:

Description

If theme and plugin button will have pointer on hover, it will increase the user accessibility.
Other uploader have pointer as well.
As uploader have wide area for selecting the file.. Would be great if have pointer.


Attachments (3)

35552.patch (301 bytes) - added by Ankit K Gupta 4 years ago.
35552- Patch file
Add_Themes_‹_core.svn.wordpress.org_—_WordPress_-_2016-01-21_11.28.44.png (6.0 KB) - added by Ankit K Gupta 4 years ago.
Screenshot of uploader
35552.diff (447 bytes) - added by afercia 4 years ago.

Download all attachments as: .zip

Change History (10)

@Ankit K Gupta
4 years ago

35552- Patch file

#1 @5um17
4 years ago

  • Keywords has-patch has-screenshots added
  • Version changed from 4.4.1 to 3.9

#2 @afercia
4 years ago

Probably, the reason why these file upload inputs are not styled is because, historically, they have always been very difficult if not impossible to style due to the fact this kind of inputs depends on the operating system, especially the "browse" button. Modern browsers allow some more styling through the shadow-DOM and exotic proprietary CSS selectors but honestly I think it's better to stay away from that and do just what is proposed in this ticket :)
Using the pointer cursor is a nice, small, improvement and I don't see any reason why it shouldn't be done. +1 from me.

#3 @afercia
4 years ago

  • Milestone changed from Awaiting Review to 4.7

@afercia
4 years ago

#4 @afercia
4 years ago

Refreshed patch resets the cursor style to default if the input field is, by chance, disabled.

Last edited 4 years ago by afercia (previous) (diff)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#6 @afercia
4 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 38435:

Accessibility: Improve the file upload inputs styling.

Though browsers implement cursor: pointer on this kind of controls a bit
inconsistently, the pointer cursor styling makes more clear the button and
label are actionable controls.

Props Ankit K Gupta.
Fixes #35552.

#7 @ocean90
4 years ago

  • Type changed from feature request to defect (bug)
Note: See TracTickets for help on using tickets.