Update TinyMCE and jQuery UI button styles

[iseulde]

Even though there's a big note on top of the buttons.css since [27494], it has been ignored in all the following commits.

We need to update those files, or maybe consider moving the classes to the buttons.css file.

@helen what do you think?

[helen]

I don't recall why those styles were left in separate files, but I imagine it had something to do with the styles being loaded in different contexts. How much needs to be synced and are there situations where buttons.css isn't loaded where the other ones are?

[iseulde]

Yes, but I guess buttons.css can be made a dependency. We just need to add extra classes to that file. Happy to make a patch to review.

[iseulde]

#35612 was marked as a duplicate.

[afercia]

Related: #35604.

[iseulde]

Other button CSS:

https://core.trac.wordpress.org/browser/tags/4.4.2/src/wp-includes/functions.php#L2621

[jorbin]

@iseulde Can you make sure the styles get corrected for 4.5?

[liljimmi]

Updated jquery-ui-dialog.css and editor.css to match changes in buttons.css

[liljimmi]

I used this Diff as a guide to see what changes have been made since the note was added to the top of buttons.css

[liljimmi]

New patch without minified files

[kirasong]

@iseulde @helen: Can you please review this? Wondering if it's still on track to land for 4.5.

[iseulde]

Sure, if it's okay, will do this tomorrow morning (Europe).

[kirasong]

+1

Thanks! :D

[iseulde]

So we'd rather patch the current files again instead of moving them to buttons.css?

[kirasong]

@iseulde Whatever you think is best here. If you'd like to go the dependency route, feel free to either patch/commit that way, or punt.

I don't mind if we commit the current approach (bringing the files up to date), then handle it differently for 4.6, if that makes the most sense.

[helen]

In late beta, yes, let's patch a file and not go messing with what depends on which.

[iseulde]

Good for now?

[iseulde]

In 37076:

Update TinyMCE and jQuery UI button styles

Part props liljimmi.
Fixes #35571.