WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#35579 closed defect (bug) (fixed)

Customizer panel wrong position if Site Title is empty

Reported by: halftones Owned by: westonruter
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.0
Component: Customize Keywords: needs-patch
Focuses: ui, javascript Cc:

Description

If "Site Title" option (in "Site Identity" panel) is empty – customizer stick to the top – under the "Save & Publish" option (by the way – why it's "Save&Publish" – there is no "Save" and no "Publish" separately – so it's just "Save" I think)

Attachments (2)

Снимок экрана 2016-01-22 в 18.01.09.png (39.1 KB) - added by halftones 4 years ago.
35579.diff (1.9 KB) - added by westonruter 4 years ago.

Download all attachments as: .zip

Change History (10)

@westonruter
4 years ago

#1 in reply to: ↑ description @westonruter
4 years ago

  • Focuses javascript added; performance removed
  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.5
  • Owner set to westonruter
  • Status changed from new to accepted
  • Version changed from 4.4.1 to 4.0

Replying to halftones:

If "Site Title" option (in "Site Identity" panel) is empty – customizer stick to the top – under the "Save & Publish" option

Yes, absolutely. Good catch. I've also noticed this bug when working on #34893 when emptying out the site title. The solution I think is just to supply some default text, e.g. “(Untitled)”, when no blogname is present. See 35579.diff.

(by the way – why it's "Save&Publish" – there is no "Save" and no "Publish" separately – so it's just "Save" I think)

This came up recently on #35547, and I commented there:

In the Customize Snapshots plugin, the “Save & Publish” buttons are actually split up into two separate buttons, “Save” and “Publish”, where the former serves to create a draft and the latter actually makes them live. This plugin is a feature plugin to implement aspects of transactions (#30937). This being said, the “Save & Publish” buttons may get split up in Core after transactions land, and I'm wary to create a new filter for this one button right now.

#2 @halftones
4 years ago

If I don't have this Customize Snapshots plugin installed (like everyone else). So for me it's just a logic. I don't actually "Publish" anything with customizer. I just want to "Save". I don't insist but it's logically right.

#3 @westonruter
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 36388:

Customizer: Use "(Untitled)" as site title if blogname is empty.

Fixes a layout issue in the Customizer UI. Also de-duplicate title display logic, outputting "Loading..." as site title in PHP with actual title being set upon Customizer ready. Also update the site title in response to a blogname setting change as opposed to input DOM events on the control.

Fixes #35579.

#4 @westonruter
4 years ago

#35129 was marked as a duplicate.

#5 follow-up: @ocean90
4 years ago

  • Keywords needs-patch added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

If a user hasn't the manage_option capability the panel title doesn't get updated so it's always Loading….

#6 @westonruter
4 years ago

  • Status changed from reopened to accepted

#7 @westonruter
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 36606:

Customize: Fix "Loading..." message from persisting in panel title when user does not have manage_options cap to edit blogname.

Reverts part of [36388].

Fixes #35579.

#8 in reply to: ↑ 5 @westonruter
4 years ago

Replying to ocean90:

If a user hasn't the manage_option capability the panel title doesn't get updated so it's always Loading….

Related: #35895

Note: See TracTickets for help on using tickets.