WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 5 months ago

#35587 new defect (bug)

If core in under version control, don't let the user update manually

Reported by: iseulde Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: Cc:
PR Number:

Description

If core is under version control, I don't think the user should be able to manually update it (and break it). I know auto updates are disabled in this case, but shouldn't manual updates be disabled too?

E.g. WordPress is installed in a subdirectory and syncs trunk every hour. A manual update would revert the changes back to the last nightly build until the next sync.

Attachments (1)

Screen Shot 2016-01-23 at 11.16.38.png (146.9 KB) - added by iseulde 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @TobiasBg
4 years ago

Please no.

Just because I have my WP installation under version control doesn't mean that I don't want to use the Update button.

It probably makes more sense to set the DISALLOW_FILE_MODS constant on a setup that auto-syncs trunk. With that constant, updates are also disabled, if I remember correctly.

#2 @swissspidy
4 years ago

What about showing a warning/notice instead?

#3 @iseulde
4 years ago

DISALLOW_FILE_MODS will prevent anyone from updating anything else.

#4 @iseulde
4 years ago

It's also weird to see "A new version of WP is available" when it's actually an old one.

#5 @iseulde
4 years ago

Sorry I just realised the screen shot is not in English. :)

Note: See TracTickets for help on using tickets.