WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 8 years ago

#35592 closed defect (bug) (fixed)

Description of button 'Clear inactive widgets' not hiding when closing section

Reported by: mahu2401's profile mahu2401 Owned by: rachelbaker's profile rachelbaker
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.4.1
Component: Widgets Keywords: has-patch commit
Focuses: administration Cc:

Description

If you close the section "Inactive widgets" with the little triangle on the right which appears if you hover it the list and the button "Clear inactive widgets" get hidden. The description of the button ('This will clear all items from the inactive widgets list. You will not be able to restore any customizations.') ist not hidden and shown under the heading. I think that is a bit confusing because there is no button any more.

Attachments (3)

screenshot1.png​ (10.9 KB) - added by mahu2401 9 years ago.
screenshot2.png​ (6.1 KB) - added by mahu2401 9 years ago.
35592.diff​ (469 bytes) - added by welcher 8 years ago.
Adding description to be hidden as well

Download all attachments as: .zip

Change History (14)

@mahu2401
9 years ago

@mahu2401
9 years ago

#1 @welcher
8 years ago

  • Focuses administration added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.5.1

Hello! Thanks for reporting this.

I've added a first pass at this but please feel free to add to it or suggest another approach!

@welcher
8 years ago

Adding description to be hidden as well

#2 @swissspidy
8 years ago

  • Milestone changed from 4.5.1 to 4.6

Patch looks good.

Changing milestone because it's not a regression in 4.5.

#3 @mahu2401
8 years ago

Works great!

#4 @welcher
8 years ago

  • Owner set to welcher
  • Status changed from new to assigned

#5 @welcher
8 years ago

  • Keywords dev-feedback added

#6 @welcher
8 years ago

  • Keywords early added; dev-feedback removed

This ticket was mentioned in ​Slack in #core by welcher. ​View the logs.
8 years ago

#8 @rachelbaker
8 years ago

  • Keywords commit added

#9 @rachelbaker
8 years ago

  • Owner changed from welcher to rachelbaker
  • Status changed from assigned to reviewing

#10 @ocean90
8 years ago

  • Keywords early removed

#11 @rachelbaker
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 37323:

Widgets: When the Inactive Widgets section is hidden also hide the “Clear Inactive Widgets” button description text.

Props welcher.

Fixes #35592.

Note: See TracTickets for help on using tickets.