Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#35592 closed defect (bug) (fixed)

Description of button 'Clear inactive widgets' not hiding when closing section

Reported by: mahu2401 Owned by: rachelbaker
Priority: normal Milestone: 4.6
Component: Widgets Version: 4.4.1
Severity: normal Keywords: has-patch commit
Cc: Focuses: administration

Description

If you close the section "Inactive widgets" with the little triangle on the right which appears if you hover it the list and the button "Clear inactive widgets" get hidden. The description of the button ('This will clear all items from the inactive widgets list. You will not be able to restore any customizations.') ist not hidden and shown under the heading. I think that is a bit confusing because there is no button any more.

Attachments (3)

screenshot1.png (10.9 KB ) - added by mahu2401 11 years ago.
screenshot2.png (6.1 KB ) - added by mahu2401 11 years ago.
35592.diff (469 bytes ) - added by welcher 10 years ago.
Adding description to be hidden as well

Download all attachments as: .zip

Change History (14)

@mahu2401
11 years ago

@mahu2401
11 years ago

#1 @welcher
10 years ago

  • Focuses administration added
  • Keywords has-patch added
  • Milestone Awaiting Review4.5.1

Hello! Thanks for reporting this.

I've added a first pass at this but please feel free to add to it or suggest another approach!

@welcher
10 years ago

Adding description to be hidden as well

#2 @swissspidy
10 years ago

  • Milestone 4.5.14.6

Patch looks good.

Changing milestone because it's not a regression in 4.5.

#3 @mahu2401
10 years ago

Works great!

#4 @welcher
10 years ago

  • Owner set to welcher
  • Status newassigned

#5 @welcher
10 years ago

  • Keywords dev-feedback added

#6 @welcher
10 years ago

  • Keywords early added; dev-feedback removed

This ticket was mentioned in Slack in #core by welcher. View the logs.


10 years ago

#8 @rachelbaker
10 years ago

  • Keywords commit added

#9 @rachelbaker
10 years ago

  • Owner changed from welcher to rachelbaker
  • Status assignedreviewing

#10 @ocean90
10 years ago

  • Keywords early removed

#11 @rachelbaker
10 years ago

  • Resolutionfixed
  • Status reviewingclosed

In 37323:

Widgets: When the Inactive Widgets section is hidden also hide the “Clear Inactive Widgets” button description text.

Props welcher.

Fixes #35592.

Note: See TracTickets for help on using tickets.