![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 10 years ago
Closed 10 years ago
#35620 closed defect (bug) (fixed)
Some WP_List_Table links for users preserve removable query args
| Reported by: | desrosj | Owned by: | rachelbaker |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.6 |
| Component: | Users | Version: | |
| Severity: | normal | Keywords: | good-first-bug has-patch commit |
| Cc: | Focuses: | administration |
Description
When certain actions are performed in the user admin and query args are used to relay notices, the arguments are preserved in certain links on the page.
To reproduce:
- Go to a user admin screen with pagination active.
- Use the select at the top of the page to change a user's role on the current screen.
- Click on a pagination link to go to a different page.
Notice that while the query arg is gone (I believe from improved admin notices related functionality: https://make.wordpress.org/core/2015/04/23/spinners-and-dismissible-admin-notices-in-4-2/), the notice will persist when clicking through pagination.
The query arg also persists in the page form's hidden referrer field.
Attachments (2)
Change History (9)
#2
@
10 years ago
- Component Administration → Users
- Keywords needs-patch good-first-bug added
- Milestone Awaiting Review → Future Release
- Version trunk
#3
@
10 years ago
I tested this, and the patch works correctly.
The message is not shown when jumping to other pages, using the pagination, after updating the role. i.e. the message correctly disappears on subsequent pages.
The list jumps to page 1, after changing the role, but this was the behaviour before the patch also.
#4
@
10 years ago
- Keywords has-patch added; needs-patch removed
- Owner set to
- Status new → assigned
Assigning to mark the good-first-bug as "claimed".
See 35620.diff
#5
@
10 years ago
- Keywords commit added
- Milestone Future Release → 4.6
- Owner changed from to
- Status assigned → accepted
#6
@
10 years ago
35620.1.diff adds the keyboard navigation query vars to wp_removable_query_args() and passes the results of said function to remove_query_var() on pagination.
Possibly related #32692