oEmbed Link Handling Can't Be Refired

[JamesDiGioia]

On page load, the oEmbed script adds a click handler to anchor tags to postMessage to the parent window to handle and redirect the user. I have two questions/issues about this.

First, i'm doing syntax highlighting in the iframe, and part of that is to add (if the user is logged in) a link to the edit the code on the backend. Because the initial oEmbed script has already run by the time this happens, I have to manually add that handler myself, which results in some code duplication between my plugin and WordPress. Is it possible to mitigate this issue by making the mechanism available outside of the IIFE scope?

[swissspidy]

Thanks for your report. Supporting lazy-loaded content sounds like something we should support automatically.

We're currently using

var links = document.getElementsByTagName( 'a' );
for ( i = 0; i < links.length; i++ ) {
	links[ i ].addEventListener( 'click', linkClickHandler );
}

whereas we might just use something like

document.addEventListener( 'click', 'linkClickHandler' );

This would require/allow us to to simplify the logic inside linkClickHandler().

If this is already enough, we could look into making things available under the wp namespace at a later point, e.g. functions like wp.embed.send_some_stuff().

[JamesDiGioia]

Patch1

[JamesDiGioia]

First patch, but I think I did this right. I didn't really see a way to simplify the logic that much, since we still need to check the parentNode.

[JamesDiGioia]

Removed extra space, proper naming.

[JamesDiGioia]

Friend of mine suggested the diff name needs to be <ticket#>.<patch#>.diff. This rectifies that and removes the extra line break I added by accident.

[chriscct7]

@swissspidy can you review the latest patch for merge potential?

[swissspidy]

I haven't found any problems with document.addEventListener() being slow or anything, so that looks good to me.

[swissspidy]

In 36637:

Embeds: Make the click event handler work for dynamically added links.

Props JamesDiGioia.
Fixes #35630.