Possible PHP notice when updating Site Info

[flixos90]

When updating a site's domain & path in the "Info" tab of Site Info, it can lead to a PHP notice being shown if a path is not included.
While paths are a crucial part to working with subdirectory installs, they are not really used on subdomain installs. In my opinion you should be able to enter http://example.com without appending the trailing slash, and WordPress should handle this automatically. Basically, if there's no trailing slash, assume the path is simply '/', otherwise take what's provided.

The notice is being generated because if you do not provide a path, the path key from parse_url() is not available. This is it:
Notice: Undefined index: path in /Volumes/HDD/user/site/web/core/wp-admin/network/site-info.php on line 83

[kjbenk]

This does not sound like a major issue but here is a patch to check for each part of the URL that is needed. If the URL is not valid it will tell the user.

[flixos90]

Thanks for the patch @kjbenk. However I'd rather have it detect whether the path is set, and otherwise simply define a path of only a trailing slash. I think showing an error message would confuse the user here.

[kjbenk]

Replying to flixos90:

I'd rather have it detect whether the path is set, and otherwise simply define a path of only a trailing slash. I think showing an error message would confuse the user here.

I am not 100% familiar with how the site url affects multisite but would this create any unwanted affects?

[flixos90]

Replying to kjbenk:

Replying to flixos90:

I'd rather have it detect whether the path is set, and otherwise simply define a path of only a trailing slash. I think showing an error message would confuse the user here.

I am not 100% familiar with how the site url affects multisite but would this create any unwanted affects?

It won't since basically, there should not be any difference in whether you specify a URL with or without trailing slash. However, every site needs to have a path (when using subdomains only, this path is '/') - so if you don't specify a path, we can safely assume it is the '/' I think.

[kjbenk]

Patch v2 to set the path? index to "/" if not set.

[flixos90]

@kjbenk Thanks, that looks good in my opinion!

[jeremyfelt]

In 36561:

Multisite: Avoid a PHP Notice when saving a site address without a path.

Props kjbenk.
Fixes #35631.