Opened 9 years ago
Closed 9 years ago
#35632 closed defect (bug) (fixed)
Show home URL instead of site URL on site info
Reported by: | flixos90 | Owned by: | jeremyfelt |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Networks and Sites | Keywords: | has-patch |
Focuses: | multisite | Cc: |
Description
In the "Info" tab of the "Site Info" screen the site URL is currently being shown for the main site of the network. This feels wrong to me, I think it should rather show the home URL since this is the URL that you can access the site's frontend at. When you use a custom directory structure, seeing a URL like http://example.com/wp
is misleading to me.
Attachments (4)
Change History (10)
#1
@
9 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to Future Release
#2
@
9 years ago
- Milestone changed from Future Release to 4.5
Agreed, changing this makes sense. The primary purpose of this field is to update the domain
and path
fields associated with the site in wp_blogs
. We only update the home
and siteurl
options when the previously set domain and path match exactly.
We should change this to be prefilled with the current domain/path combination and use Eric's suggested Site Address (URL)
for parity with single site.
#3
@
9 years ago
- Keywords has-patch added; needs-patch removed
In 35632.2.diff I changed the field label to Site Address (URL)
#4
@
9 years ago
@rachelbaker:
Based on your patch, 35632.3.diff changes the usage of siteurl
to home
to be consistent with the usage on non-multisite installs and to actually show the correct site address in case someone uses a custom directory structure with WordPress in a subdirectory.
#5
@
9 years ago
35632.4.diff uses the combination of domain and path from wp_blogs
to display the site address for the main site, which aligns with the non-main site display.
I agree. We should probably have parity with how home url is described in
Settings > General
page on single site, which isSite Address (URL)
.