WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#35632 closed defect (bug) (fixed)

Show home URL instead of site URL on site info

Reported by: flixos90 Owned by: jeremyfelt
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

In the "Info" tab of the "Site Info" screen the site URL is currently being shown for the main site of the network. This feels wrong to me, I think it should rather show the home URL since this is the URL that you can access the site's frontend at. When you use a custom directory structure, seeing a URL like http://example.com/wp is misleading to me.

Attachments (4)

35632.diff (556 bytes) - added by rachelbaker 4 years ago.
35632.2.diff (1014 bytes) - added by rachelbaker 4 years ago.
35632.3.diff (1.0 KB) - added by flixos90 4 years ago.
35632.4.diff (1.0 KB) - added by jeremyfelt 3 years ago.

Download all attachments as: .zip

Change History (10)

#1 @ericlewis
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

I agree. We should probably have parity with how home url is described in Settings > General page on single site, which is Site Address (URL).

#2 @jeremyfelt
4 years ago

  • Milestone changed from Future Release to 4.5

Agreed, changing this makes sense. The primary purpose of this field is to update the domain and path fields associated with the site in wp_blogs. We only update the home and siteurl options when the previously set domain and path match exactly.

We should change this to be prefilled with the current domain/path combination and use Eric's suggested Site Address (URL) for parity with single site.

@rachelbaker
4 years ago

@rachelbaker
4 years ago

#3 @rachelbaker
4 years ago

  • Keywords has-patch added; needs-patch removed

In 35632.2.diff I changed the field label to Site Address (URL)

https://cldup.com/YvkS3F_dCg.png

@flixos90
4 years ago

#4 @flixos90
4 years ago

@rachelbaker:
Based on your patch, 35632.3.diff changes the usage of siteurl to home to be consistent with the usage on non-multisite installs and to actually show the correct site address in case someone uses a custom directory structure with WordPress in a subdirectory.

Last edited 4 years ago by flixos90 (previous) (diff)

@jeremyfelt
3 years ago

#5 @jeremyfelt
3 years ago

35632.4.diff uses the combination of domain and path from wp_blogs to display the site address for the main site, which aligns with the non-main site display.

#6 @jeremyfelt
3 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 36682:

Multisite: Show the main site's domain and path in site-info.php

  • Use the domain and path combination from wp_blogs when displaying the site address for the main site.\
  • Update the text from "Site URL" to "Site Address (URL)" for all sites in site-info.php to better align with how we refer to this in single site.

Props flixos90, rachelbaker.
Fixes #35632.

Note: See TracTickets for help on using tickets.