WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#35663 closed defect (bug) (duplicate)

Focus inside theme modal dialog window under Appearance >> Themes

Reported by: sami.keijonen Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots
Focuses: ui, accessibility, javascript Cc:
PR Number:

Description

I was checking Appearance >> Themes using keyboard only: Tab, Shift+Tab and Enter. When I open the first and active theme modal dialog window, focus is acting weird.

  1. Focus is not set on the first focusable element. It goes to the Customize link.
  2. Focus does not stay inside the modal dialog window when tabbing.
  3. Both of these works fine when I open the second, non active theme.

https://cldup.com/trctDCIn1k.jpg

When I open any non active theme modal dialog I noticed also couple of focus issues.

  1. I can't focus on Delete theme button when tabbing trough the theme modal window on non active theme.
  2. But when focus is on Show previous theme button I can focus the Delete theme button when I use Shift+Tab.
  3. But then again if I continue Shift+Tab, focus is locked between Show previous theme and Delete buttons.

https://cldup.com/5KgfXRRk27.jpg

Change History (5)

This ticket was mentioned in Slack in #accessibility by sami.keijonen. View the logs.


4 years ago

#2 @afercia
4 years ago

  • Component changed from General to Administration
  • Focuses ui javascript added
  • Keywords needs-patch has-screenshots added

Thanks @sami.keijonen!

#3 @afercia
3 years ago

  • Keywords reporter-feedback added

@sami.keijonen hi, sorry I forgot about this ticket and the Themes browser has been reviewed a bit in #37383. The main focus issues are fixed now in trunk and will land in WordPress 4.6. Can you confirm all the things you noticed are working better now? Thanks!

#4 @sami.keijonen
3 years ago

Looks better now, thanks!

#5 @afercia
3 years ago

  • Keywords needs-patch reporter-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version 4.4.1 deleted

Fixed in #37383.

Note: See TracTickets for help on using tickets.