Opened 9 years ago
Closed 9 years ago
#35670 closed defect (bug) (wontfix)
Avoid using HTML tags in translation strings (network documentation links)
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch |
Focuses: | Cc: |
Description
The documentation links in help tabs are translatable. But the translation strings contain the HTML <a>
tags with the links.
The attached patch fixes this, moving the HTML tag out of the translation string.
In this ticket I've started with the network documentation links. If the ticket will be approved, I'll fix documentation links in other help tabs.
This ticket is a part of my core i18n improvements project.
Attachments (3)
Change History (10)
#2
@
9 years ago
- Keywords has-patch added
I can replace:
esc_url( 'https://codex.wordpress.org/Tools_Network_Screen' )
With:
esc_url( __( 'https://codex.wordpress.org/Tools_Network_Screen' ) )
#3
@
9 years ago
I can also do that with sprintf()
for documentation strings:
sprintf( '<a href="%1$s" target="_blank">%2$s</a>' __( 'https://codex.wordpress.org/XXX' ), __( 'Documentation on XXX' ), )
This ticket was mentioned in Slack in #core-i18n by ocean90. View the logs.
9 years ago
This ticket was mentioned in Slack in #core-i18n by ocean90. View the logs.
9 years ago
#7
@
9 years ago
- Milestone 4.6 deleted
- Resolution set to wontfix
- Status changed from new to closed
Closing as wontfix as per https://wordpress.slack.com/archives/core-i18n/p1467746297000038.
The codex links should be still translatable.