WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#35672 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/user-edit.php)

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (2)

35672.patch​ (844 bytes) - added by ramiy 8 years ago.
35672.2.patch​ (863 bytes) - added by ramiy 8 years ago.

Download all attachments as: .zip

Change History (9)

@ramiy
8 years ago

#1 @ramiy
8 years ago

  • Keywords has-patch added

In this patch I've moved the <a href="%2$s">Cancel</a> part into a separate translation string. And also I've added a translator comment to the original string.

#2 @ramiy
8 years ago

Related: #35673

#3 @ramiy
8 years ago

Old string:

  • There is a pending change of your email to %1$s. <a href="%2$s">Cancel</a>

New strings:

  • There is a pending change of your email to %s.
  • Cancel

This ticket was mentioned in ​Slack in #core-i18n by ramiy. ​View the logs.
8 years ago

@ramiy
8 years ago

#5 @ramiy
8 years ago

The patch also adds translators comment.

#6 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36655:

I18N: Remove <a> tag from translatable string in wp-admin/user-edit.php.

Add translator comment.

Props ramiy.
Fixes #35672.

#7 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.5
Note: See TracTickets for help on using tickets.