#35675 closed defect (bug) (fixed)
Avoid using HTML tags in translation strings (wp-admin/custom-header.php)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch |
Focuses: | Cc: |
Description
See the attached patch.
- remove the
<strong>
tag from the string. - add translators comments.
- split into smaller strings.
- use
%s
and%d
instead of%1$d
.
Generally, this patch creates 3 simpler strings without HTML tags, from 2 strings with HTML tags.
Attachments (2)
Change History (8)
#3
@
9 years ago
Old strings:
Images should be at least <strong>%1$d pixels</strong> wide.
Images should be at least <strong>%1$d pixels</strong> tall.
Suggested width is <strong>%1$d pixels</strong>.
Suggested height is <strong>%1$d pixels</strong>.
New strings:
Images should be at least %s wide.
Images should be at least %s tall.
Suggested width is %s.
Suggested height is %s.
%d pixels
As you can see the new string has no HTML tags, and they are easier to translate.
This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.
9 years ago
Note: See
TracTickets for help on using
tickets.
Found two more strings! See the second patch. Same principle.