WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#35676 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/includes/class-wp-ms-sites-list-table.php)

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Moving the <em> HTML tag out of the translation string.

Attachments (2)

35676.patch​ (729 bytes) - added by ramiy 8 years ago.
35676.2.patch​ (823 bytes) - added by ramiy 8 years ago.
easier to read code

Download all attachments as: .zip

Change History (7)

@ramiy
8 years ago

@ramiy
8 years ago

easier to read code

#1 @ramiy
8 years ago

  • Keywords has-patch added

#2 @ramiy
8 years ago

Old string:

  • %1$s &#8211; <em>%2$s</em>

New string:

  • %1$s &#8211; %2$s

This ticket was mentioned in ​Slack in #core-i18n by ramiy. ​View the logs.
8 years ago

#4 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36663:

I18N: Remove <em> tag from translatable string in wp-admin/includes/class-wp-ms-sites-list-table.php.

Props ramiy.
Fixes #35676.

#5 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.5
Note: See TracTickets for help on using tickets.