WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 19 months ago

Last modified 19 months ago

#35679 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/plugins.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (2)

35679.patch (1.4 KB) - added by ramiy 20 months ago.
35679.2.patch (1.4 KB) - added by ramiy 20 months ago.

Download all attachments as: .zip

Change History (11)

@ramiy
20 months ago

@ramiy
20 months ago

#1 @ramiy
20 months ago

  • Keywords has-patch added

#2 @ramiy
20 months ago

Old strings:

  • <strong>%1$s</strong> by <em>%2$s</em> (will also <strong>delete its data</strong>)
  • <strong>%1$s</strong> by <em>%2$s</em>

New strings:

  • %1$s by %2$s
  • (will also <strong>delete its data</strong>)

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


20 months ago

This ticket was mentioned in Slack in #core-i18n by akirk. View the logs.


20 months ago

#5 @SergeyBiryukov
19 months ago

(will also <strong>delete its data</strong>) is confusing by itself (what would delete its data)?

I would suggest just moving the tags into placeholders:

  • %1$s by %2$s (will also <strong>delete its data</strong>)
  • %1$s by %2$s

The latter string also probably needs a context, to avoid clashing with the one in media_handle_upload() if we remove the trailing dot there at some point.

#6 @ramiy
19 months ago

  • Keywords close added

Ok, close this ticket.

#7 @SergeyBiryukov
19 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36662:

I18N: Remove HTML tags from translatable strings in wp-admin/plugins.php.

Props ramiy.
Fixes #35679.

#8 @SergeyBiryukov
19 months ago

  • Milestone changed from Awaiting Review to 4.5

#9 @ocean90
19 months ago

  • Keywords close removed
Note: See TracTickets for help on using tickets.