Default HTTP schema when adding a custom link

[isdampe]

When editing menus in Wordpress (nav-menus.php), the "Custom links" accordion input box always defaults to ​http://

I feel this should default to ​https:// if the WP install is running on SSL.

I can't speak for all, but I mostly use custom links for custom links that are already on my site, and if I'm running SSL, then I need to manually change ​http:// to ​https:// each time.

Most sites running SSL will only link to other secure sites and resources too, so this may be another point of confirmation.

[Clorith]

I wonder if the default value should perhaps be filterable at this point, as core becomes more open to interactions outside of the normal URL scope?

Creating a filter like wp_nav_menu_default_prefix might be an idea here, and also escaping the value before outputting it in the form.

[johnbillion]

The current URL's scheme is not relevant to the home URL scheme (for example, sites that use FORCE_ADMIN_SSL but don't serve the front end over HTTPS).

My preference here would be to remove the default value entirely.

[christophherr]

Removes the default value from the Custom Links URL input field

[christophherr]

The uploaded 35685.diff removes the default value.
I guess the UI change needs some feedback.

[karmatosed]

@christophherr I agree that removing the default all together works. However, I notice it's only been removed through Appearance > Menus. It should also be removed in the Customizer menu interactions. If that can happen, I would agree this is ready to consider for commit, thanks.

[christophherr]

Updated patch removes the default value from the Custom Links URL input field from Appearance - Menus and Appearance - Customize - Menus interactions

[christophherr]

Thank you, @karmatosed.

I attached an updated patch that removes the default value from the Customizer menu interactions as well.

[karmatosed]

@christophherr unfortunately I don't seem to be able to get the patch to work. Could you check the patch again, please?

[christophherr]

Sorry about that.
I only tested with svn patch not with grunt patch.
I uploaded a new patch through grunt upload_patch.
It applies for me now with svn patch and grunt patch.

[sabernhardt]

Changed from http:// value to https:// placeholder in [46330]