Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#35686 closed defect (bug) (fixed)

Fix global tag for admin bar functions

Reported by: Frozzare Owned by: DrewAPicture
Priority: normal Milestone: 4.5
Component: Toolbar Version: 4.3
Severity: normal Keywords: needs-patch
Cc: Focuses: docs

Description

Both show_admin_bar and is_admin_bar_showing has wrong global variable name for WP_Admin_Bar. It should be $show_admin_bar instead of $wp_admin_bar since the code use $show_admin_bar.

Attachments (1)

35686.patch​ (622 bytes ) - added by Frozzare 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @Frozzare
11 years ago

  • Keywords has-patch added

#2 @DrewAPicture
11 years ago

  • Milestone Awaiting Review → 4.5
  • Type enhancement → defect (bug)

Hi @Frozzare, thanks for the patch, nice catch :-)

#3 @DrewAPicture
11 years ago

  • Owner set to DrewAPicture
  • Resolution → fixed
  • Status new → closed

In 36491:

Docs: Fix two notations in the DocBlocks for show_admin_bar() and is_admin_bar_showing() to reflect use of the $show_admin_bar global rather than $wp_admin_bar.

Props Frozzare.
Fixes #35686.

#4 @johnbillion
11 years ago

  • Component Administration → Toolbar
  • Keywords needs-patch added; has-patch removed
  • Resolution fixed
  • Status closed → reopened

$show_admin_bar is a boolean, not a WP_Admin_Bar.

#5 @johnbillion
11 years ago

  • Version trunk → 4.3

#6 @DrewAPicture
11 years ago

  • Resolution → fixed
  • Status reopened → closed

In 36601:

Docs: Fix two incorrect notations of the $show_admin_bar global to specify a boolean type, not WP_Admin_Bar.

See [36491]. Fixes #35686.

Note: See TracTickets for help on using tickets.