Make WordPress Core

Opened 7 years ago

Closed 8 months ago

#35694 closed defect (bug) (invalid)

Types of some attachment metadata has changed

Reported by: imath's profile imath Owned by: ocean90's profile ocean90
Milestone: Priority: normal
Severity: normal Version: 4.4.2
Component: Media Keywords: close
Focuses: Cc:


Since r36429 when you use wp_read_image_metadata() the ["image_meta"]["orientation"] is no more an integer but a string.

I've noticed it because it made a BuddyPress unit test fail. I don't know if this could have an impact somewhere, so i thought it was best to report it here just in case.

Change History (5)

#1 @obenland
7 years ago

  • Owner set to ocean90
  • Status changed from new to assigned
  • Version changed from trunk to 4.4.2

#2 @ocean90
7 years ago

Looks like it's the case for created_timestamp (int), orientation (int) and aperture (float)? Are there more?

#3 @desrosj
10 months ago

  • Keywords close added
  • Milestone set to Awaiting Review

Found this in a list of tickets without a milestone.

I'm not clear what needs to be done here. It seems this was a "let's keep an eye out for adverse effects" ticket, but I don't think any have come up since it has been 6+ years.

I took a look and wp_read_image_metadata() does not seem to have expanded documentation of meta values that may be present, so there are no incorrect types listed. Seems this can be closed out.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.

8 months ago

#5 @antpb
8 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from assigned to closed

I agree with the above comment. Since this has not seen any issues in ~7 years we can close this. Feel free to reopen if incorrect!

Note: See TracTickets for help on using tickets.