WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#35712 closed defect (bug) (fixed)

urldecode for search Param in plugins.php Page

Reported by: sebastian.pisula Owned by: ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: needs-patch
Focuses: administration Cc:

Description

During search plugin for example "WordPress Importer" I see text: "Search results for "WordPress+Importer"

Attachments (1)

35712.patch (847 bytes) - added by sebastian.pisula 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @sebastian.pisula
5 years ago

  • Keywords has-patch added

This patch fixed search plugins with two words. I can't found plugin with name for example: "LayerSlider WP"

#2 @afercia
5 years ago

I think $s must be encoded since it's used also in other places (for example for a redirect). By the way it shouldn't be used for the search title and maybe there's the need for a new variable?
Worth noting this happens also in the Themes screens, I guess for different reasons since they're JS based. For example, search for "Twenty Eleven" and then refresh the page: the content of the search field changes in "Twenty+Eleven".

#3 @johnbillion
5 years ago

  • Focuses administration added
  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to 4.5

#4 @ocean90
5 years ago

Introduced in [18452].

#5 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 36560:

Plugins: Remove slashes from search terms and use urldecode() in non-URL contexts.

Fixes #35712.

Note: See TracTickets for help on using tickets.