WordPress.org

Make WordPress Core

Opened 23 months ago

#35717 new defect (bug)

Audit the .icon16 selectors in admin-menu.css

Reported by: afercia Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: needs-patch dev-feedback
Focuses: ui Cc:

Description

Noticed while investigating the admin stylesheets for color contrast, looks like the .icon16 selectors in admin-menu.css are no more used. I'm not 100% sure and I'd really appreciate some feedback though.

As far as I see, the .icon16 selectors were used only for the Welcome Panel at some point, while the admin menu always used its own selectors. It seems to me they can be safely removed.

Some history:
Introduced in WordPress 3.3 to reuse the admin menu icons on the Welcome Screen, see [19163] and [19197].

The icons were then removed with the Welcome Panel redesign for WP 3.5, see [22018] and #21368.

The selectors were still present in the MP6 stylesheets, see [26072], but no more used in any screen? If so, it would be a nice opportunity to do some cleaning.

Attachments (1)

35717.0.patch (2.8 KB) - added by mmaumio 20 months ago.
Removed the .icon16 class from wp-admin/admin-menu.css

Download all attachments as: .zip

Change History (1)

@mmaumio
20 months ago

Removed the .icon16 class from wp-admin/admin-menu.css

Note: See TracTickets for help on using tickets.