WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#35718 closed defect (bug) (invalid)

Avoid using HTML tags in translation strings (wp-admin/maint/repair.php)

Reported by: ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:
PR Number:

Description

See the attached patch.

Attachments (3)

35718.patch (1.2 KB) - added by ramiy 4 years ago.
35718.2.patch (1.2 KB) - added by ramiy 4 years ago.
Add esc_url()
35718.3.patch (1.2 KB) - added by ramiy 4 years ago.
use sprintf()

Download all attachments as: .zip

Change History (7)

@ramiy
4 years ago

@ramiy
4 years ago

Add esc_url()

#1 @ramiy
4 years ago

  • Keywords has-patch added

#2 @ramiy
4 years ago

Old string:

  • While you are editing your %1$s file, take a moment to make sure you have all 8 keys and that they are unique. You can generate these using the <a href="%2$s">WordPress.org secret key service</a>.

New strings:

  • While you are editing your %1$s file, take a moment to make sure you have all 8 keys and that they are unique. You can generate these using the %2$s.
  • https://api.wordpress.org/secret-key/1.1/salt/
  • WordPress.org secret key service

@ramiy
4 years ago

use sprintf()

#3 @swissspidy
4 years ago

https://api.wordpress.org/secret-key/1.1/salt/ isn't currently translatable and I don't think it should be now. What would one translate this to?

#4 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

The original string seems perfectly fine here.

Note: See TracTickets for help on using tickets.