Opened 10 years ago
Closed 9 years ago
#35721 closed defect (bug) (fixed)
Translation strings Improvements (wp-admin/includes/update.php)
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.6 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | I18N | Keywords: | has-patch has-screenshots |
| Focuses: | Cc: |
Description
First open the attached patch.
This change has few improvements:
- Added translators comments for wordpress version.
- The
aria-labeltext is now translatable.
- Splitting the two old string to two parts, the warning and the call-to-action.
- The warning string
WordPress %s is available!was moved to a separate string.
- Then call-to-action string, comes after we check if the user has permission to update core. If the user can update, the message is
Please update now, if not the message isPlease notify the site administrator.
- The string where it say's
Please update nowwas stripped out of the HTML<a>tag. It was moved outside the translation string.
Old Strings:
<a href="https://codex.wordpress.org/Version_%1$s">WordPress %1$s</a> is available! <a href="%2$s">Please update now</a>.
<a href="https://codex.wordpress.org/Version_%1$s">WordPress %1$s</a> is available! Please notify the site administrator.
New Strings:
<a href="https://codex.wordpress.org/Version_%s">WordPress %s</a> is available!
Please update now
Please notify the site administrator.
And the new added aria-label text: Please update WordPress now.
Attachments (3)
Change History (8)
Note: See
TracTickets for help on using
tickets.
The second patch is replacing
https://codex.wordpress.org/Version_%swith a placeholder.I also added
esc_url()for this URL.