WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#35721 closed defect (bug) (fixed)

Translation strings Improvements (wp-admin/includes/update.php)

Reported by: ramiy Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch has-screenshots
Focuses: Cc:
PR Number:

Description

First open the attached patch.

This change has few improvements:

  1. Added translators comments for wordpress version.
  1. The aria-label text is now translatable.
  1. Splitting the two old string to two parts, the warning and the call-to-action.
  1. The warning string WordPress %s is available! was moved to a separate string.
  1. Then call-to-action string, comes after we check if the user has permission to update core. If the user can update, the message is Please update now, if not the message is Please notify the site administrator.
  1. The string where it say's Please update now was stripped out of the HTML <a> tag. It was moved outside the translation string.

Old Strings:

  • <a href="https://codex.wordpress.org/Version_%1$s">WordPress %1$s</a> is available! <a href="%2$s">Please update now</a>.
  • <a href="https://codex.wordpress.org/Version_%1$s">WordPress %1$s</a> is available! Please notify the site administrator.

New Strings:

  • <a href="https://codex.wordpress.org/Version_%s">WordPress %s</a> is available!
  • Please update now
  • Please notify the site administrator.

And the new added aria-label text: Please update WordPress now.

Attachments (3)

Translations Hebrew Administration GlotPress — WordPress.png (30.3 KB) - added by ramiy 4 years ago.
35721.patch (1.2 KB) - added by ramiy 4 years ago.
35721.2.patch (1.3 KB) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-patch has-screenshots added

This ticket was mentioned in Slack in #core-i18n by dd32. View the logs.


4 years ago

@ramiy
4 years ago

#3 @ramiy
4 years ago

The second patch is replacing https://codex.wordpress.org/Version_%s with a placeholder.

I also added esc_url() for this URL.

#4 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to 4.6
  • Owner set to ocean90
  • Status changed from new to reviewing

#5 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 37675:

I18N: Simplify the WordPress update notice for translators.

  • Make codex URL and accessibility text separate strings.
  • Add translator comments.

Props ramiy for initial patch.
Fixes #35721.

Note: See TracTickets for help on using tickets.