WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#35724 closed defect (bug) (wontfix)

Avoid using HTML tags in translation strings (wp-load.php)

Reported by: ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (3)

35724.patch (592 bytes) - added by ramiy 4 years ago.
35724.2.patch (603 bytes) - added by ramiy 4 years ago.
35724.3.patch (640 bytes) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
4 years ago

#1 @javorszky
4 years ago

Shouldn't the url in the link tag be wrapped around esc_attr__ instead of just __?

Last edited 4 years ago by javorszky (previous) (diff)

@ramiy
4 years ago

#2 @ramiy
4 years ago

Yes, but it should be esc_url(), and the URL should be translatable to allow GTE's to select local links.

@javorszky, thanks for the feedback.

#3 @ramiy
4 years ago

  • Keywords has-patch added

#4 @ramiy
4 years ago

Old strings:

  • Need more help? <a href='%s'>We got it</a>.
  • https://codex.wordpress.org/Editing_wp-config.php

New strings:

  • Need more help? %s.
  • We got it
  • https://codex.wordpress.org/Editing_wp-config.php

@ramiy
4 years ago

#5 @ocean90
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The current string looks good as is. Fragmented strings should be avoided.

Note: See TracTickets for help on using tickets.