WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#35724 closed defect (bug) (wontfix)

Avoid using HTML tags in translation strings (wp-load.php)

Reported by: ramiy Owned by:
Priority: normal Milestone:
Component: I18N Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

See the attached patch.

Attachments (3)

35724.patch​ (592 bytes ) - added by ramiy 11 years ago.
35724.2.patch​ (603 bytes ) - added by ramiy 11 years ago.
35724.3.patch​ (640 bytes ) - added by ramiy 10 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
11 years ago

#1 @javorszky
11 years ago

Shouldn't the link in the link be wrapped around esc_attr__ instead of just __?

Version 0, edited 11 years ago by javorszky (next)

@ramiy
11 years ago

#2 @ramiy
11 years ago

Yes, but it should be esc_url(), and the URL should be translatable to allow GTE's to select local links.

@javorszky, thanks for the feedback.

#3 @ramiy
11 years ago

  • Keywords has-patch added

#4 @ramiy
11 years ago

Old strings:

  • Need more help? <a href='%s'>We got it</a>.
  • https://codex.wordpress.org/Editing_wp-config.php

New strings:

  • Need more help? %s.
  • We got it
  • https://codex.wordpress.org/Editing_wp-config.php

@ramiy
10 years ago

#5 @ocean90
10 years ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

The current string looks good as is. Fragmented strings should be avoided.

Note: See TracTickets for help on using tickets.