WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#35737 closed defect (bug) (fixed)

Login page title in RTL sites

Reported by: ramiy's profile ramiy Owned by: chriscct7's profile chriscct7
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch commit
Focuses: rtl, administration Cc:

Description

The login page title use hard-coded › HTML entity.

In RTL sites it should be ‹.

The attached patch fixes this.

Attachments (2)

35737.patch​ (894 bytes) - added by ramiy 10 years ago.
35737.2.patch​ (905 bytes) - added by ramiy 10 years ago.

Download all attachments as: .zip

Change History (9)

@ramiy
10 years ago

#1 @ramiy
10 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by chriscct7. ​View the logs.
10 years ago

#3 @chriscct7
10 years ago

Needs a quick refresh:
If changing bloginfo to echo get_bloginfo, the second param should be explicitly declared as 'display' even as the default. That way if its ever changed in the future, it's paridy to what it would have been without the patch

@ramiy
10 years ago

#4 @ramiy
10 years ago

@chriscct7, patch fixed.

#5 @chriscct7
10 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.5
  • Owner set to chriscct7
  • Status changed from new to assigned

@ramiy Thanks, looks good!

#6 @SergeyBiryukov
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36487:

Login: In login_header(), use correct separator for RTL locales.

Props ramiy.
Fixes #35737.

#7 @ramiy
10 years ago

Related: #35774 - Admin pages <title> structure

Note: See TracTickets for help on using tickets.