WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 21 months ago

Last modified 21 months ago

#35738 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/install.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (2)

35738.patch (790 bytes) - added by ramiy 22 months ago.
35738.2.patch (1.2 KB) - added by ramiy 22 months ago.

Download all attachments as: .zip

Change History (8)

@ramiy
22 months ago

#1 @ramiy
22 months ago

  • Keywords has-patch added

@ramiy
22 months ago

#2 @ramiy
22 months ago

Old strings:

  • Your <code>wp-config.php</code> file has an empty database table prefix, which is not supported.
  • The constant DO_NOT_UPGRADE_GLOBAL_TABLES cannot be defined when installing WordPress.

New strings:

  • Your %s file has an empty database table prefix, which is not supported.
  • The constant %s cannot be defined when installing WordPress.

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


21 months ago

#4 @ramiy
21 months ago

In the first string the <code>wp-config.php</code> was replaced with %s placeholder.

In the second string I add code tags to the DO_NOT_UPGRADE_GLOBAL_TABLES constant. And I replaced it with %s, moving the constant out of the string with the code tag.

#5 @SergeyBiryukov
21 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 36665:

I18N: Remove <code> tags from translatable strings in wp-admin/install.php.

Props ramiy.
Fixes #35738.

#6 @SergeyBiryukov
21 months ago

  • Milestone changed from Awaiting Review to 4.5
Note: See TracTickets for help on using tickets.