Make WordPress Core

Opened 18 years ago

Closed 18 years ago

#3574 closed defect (bug) (fixed)

Character set not specified in TinyMCE files

Reported by: ruckus's profile ruckus Owned by:
Milestone: 2.0.9 Priority: normal
Severity: major Version: 2.0.7
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Using 8-bit characters in TinyMCE translation does not work, because the output from tiny_mce_gzip.php and wp-mce-help.php does not specify any charset in Content-Type. This leaves it up to PHP and the web server to complete the Content-Type charset information, possibly incorrectly.

The charset should not be hard-coded in these scripts, so that plugins such as Character Set Conversions[1] can use the gettext hook to transcode the messages to the character set specified in the blog settings.

[1]: http:/kimmo.suominen.com/sw/charsets/

Attachments (1)

tinymce-charset.diff (1.2 KB) - added by ruckus 18 years ago.
Patch against 2.0.7-RC1

Download all attachments as: .zip

Change History (10)

@ruckus
18 years ago

Patch against 2.0.7-RC1

#1 @markjaquith
18 years ago

  • Milestone changed from 2.0.8 to 2.2

Does this apply to 2.1 or 2.2? If so, we should fix it there first.

#2 @foolswisdom
18 years ago

  • Cc nbachiyski added
  • Keywords has-patch added; bg|has-patch removed

#3 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4845]) Set charset for MCE. Props nbachiyski. fixes #3574

#4 @ryan
18 years ago

(In [4846]) Set charset for MCE. Props nbachiyski. fixes #3574

#5 @ryan
18 years ago

  • Milestone changed from 2.2 to 2.0.9

Committed for 2.2 and 2.1.1. Let's milestone for 2.0.9.

#6 @foolswisdom
18 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @ruckus
18 years ago

  • Cc ruckus added

#8 @ruckus
18 years ago

Looks like the change was applied to 2.1 and 2.2, so it applied. I'm not running the trunk (yet), so my patches tend to be against 2.0.x.

#9 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [4888]) Set charset for MCE. Props ruckus. fixes #3574

Note: See TracTickets for help on using tickets.